Project

General

Profile

Support #1470

Potential misleading terminology in utility/environment

Added by Stefan Petscharnig 12 days ago. Updated 12 days ago.

Status:
Feedback
Priority:
Low
Target version:
-
Start date:
06.08.2018
Due date:
% Done:

0%

Estimated time:

Description

In qkd/include/qkd/utility/environment.h (line 36), there is a definition for a struct called nic.

If I understood correctly this struct holds information on network interfaces. NIC is the abbreviation for network interface card, so this jas potential to mislead future users of the library.

Please share your opinion on this.

History

#1 Updated by Oliver Maurhart 12 days ago

  • Status changed from New to Feedback
  • Assignee set to Stefan Petscharnig

Stefan Petscharnig wrote:

In qkd/include/qkd/utility/environment.h (line 36), there is a definition for a struct called nic.

If I understood correctly this struct holds information on network interfaces. NIC is the abbreviation for network interface card, so this jas potential to mislead future users of the library.

Please share your opinion on this.

Yes, you're right. You suggest renaming this to ni or nif? Correctly speaking it should be a nif. However, this simply sounds a bit awkward...

Then, technically, a nic is still a nic even if there is no real card attached or physically present, e.g. a pure virtual nic.

The goal of this interface is, to manage network interface and IP addresses is a more friendly manner than the Linux kernel itself does provide already. The kernel routines are ... "cumbersome" at best.

Go for nif?

Also available in: Atom PDF